Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/transforms/compat): loose mode for class_properties #3722

Merged
merged 10 commits into from Feb 26, 2022

Conversation

Austaras
Copy link
Member

Description:

BREAKING CHANGE:

would be break change for rust user
Related issue (if exists):

@Austaras Austaras marked this pull request as draft February 24, 2022 06:44
@Austaras Austaras marked this pull request as ready for review February 26, 2022 06:14
@@ -59,7 +59,7 @@ var A = function A() {
var _foo = {
writable: true,
value: true
} // error (duplicate)
}// error (duplicate)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no actual idea why this is happening, but I guess it's fine.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • swc_ecma_utils --breaking

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... I found that CI failed

@Austaras
Copy link
Member Author

oh, my bad

@Austaras
Copy link
Member Author

This would also require a new version of @swc/helpers

@Austaras Austaras requested a review from kdy1 February 26, 2022 14:50
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 merged commit 14155eb into swc-project:main Feb 26, 2022
@kdy1 kdy1 added this to the v1.2.146 milestone Feb 26, 2022
@Austaras Austaras deleted the loose branch February 26, 2022 15:09
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants