fix(parser): Handle trailing comma and bracket after arrow fn in conditional in TS

[williamtetlow]

Description:
fixes #3672

fixes syntax

// case 1
{
  prop: a ? (): void => { } : (): void => { },
}

// case 2
f(a ? (): void => { } : (): void => { })

BREAKING CHANGE:

Related issue (if exists):
#3672

[kdy1]

Thank you!

---

swc-bump:

• swc_ecma_parser

[kdy1]

CI is failing due to parsing error.
I think we should use some context to see if we can eat ,

[williamtetlow]

Oops missed that, let me take a look

[magic-akari]

could you add another test case?

f(a ? (): void => { } : (): void => { })

[kdy1]

Can you add the test?

[williamtetlow]

Yep will do. Had a busy day with work yesterday but will do it today

[williamtetlow]

@kdy1 sorry busy week with work only just got round to fixing this.

Added test requested by @magic-akari in f6f0623

Also had to remove test for #2174. This is actually invalid syntax in TS see https://www.typescriptlang.org/play?#code/MYewdgzgLgBAHjAvDA3gKBpmAHATibALhgEsIBhEXXAU2CgyyYH4YAzMJAPhgAoUYAXwCUjJuJjEO3GFFwBXGgBo0ggNxA

[williamtetlow]

Hmm is exec_tests__deno_exec__deno_9464__case1__input__entry_ts a bit flaky? I'm getting overflowed stack error on CI but works locally?

https://github.com/swc-project/swc/runs/5331608290?check_suite_focus=true

Edit:
Looks like it might be, worked second time 🙂

[kdy1]

Why did you delete this test?

[williamtetlow]

@kdy1 I commented above. This isn't valid TS syntax

Also had to remove test for #2174. This is actually invalid syntax in TS see https://www.typescriptlang.org/play?#code/MYewdgzgLgBAHjAvDA3gKBpmAHATibALhgEsIBhEXXAU2CgyyYH4YAzMJAPhgAoUYAXwCUjJuJjEO3GFFwBXGgBo0ggNxA

[dsherret]

It's valid JavaScript though. This is just a failing of the TS compiler.

[kdy1]

Sorry, I missed it. Thanks!

[kdy1]

Thank you!

---

swc-bump:

• swc_ecma_parser