fix(codegen): fix unicode escaping in es5 #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just posting these links here for future reference https://mathiasbynens.be/notes/javascript-escapes#unicode https://mathiasbynens.be/notes/javascript-encoding#surrogate-formulae |
williamtetlow
commented
Feb 21, 2022
| v: &str, | ||
| target: EsVersion, | ||
| single_quote: bool, | ||
| emit_non_ascii_as_unicode: bool, |
There was a problem hiding this comment.
setting this to true is equivalent to disabling jsesc minimal option
kdy1
reviewed
Feb 25, 2022
crates/swc_ecma_codegen/src/lib.rs
Outdated
| } | ||
| }; | ||
|
|
||
| if target <= EsVersion::Es5 { | ||
| let emit_non_ascii_as_unicode = UNICODE_CODEPOINT.is_match(&orig); |
There was a problem hiding this comment.
The only concern about this PR I have is the performance of this line.
Do we really need regex?
kdy1
reviewed
Feb 25, 2022
kdy1
requested changes
Feb 25, 2022
kdy1
approved these changes
Feb 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #3617
Babel has the logic
if target <= ES5 && original source string contains any unicode map all non-ascii to unicode.It's a bit implicit as the logic is across a few plugins and also through the options passed to
jsesc(that depend on target and babel version) but here babel setsnode.extra = undefinedif there's any unicode in string literalAnd here if
node.extraexists it will return the string and otherwise process it withjsesc> 0xFFFFto surrogate pairs to support ES5.BREAKING CHANGE:
Related issue (if exists):
#3617