Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 1414 #1419

Merged
merged 2 commits into from Dec 12, 2022
Merged

fix issue 1414 #1419

merged 2 commits into from Dec 12, 2022

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Dec 12, 2022

Describe the PR
split security attribute with any space character

Relation issue
#1414

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 85.16% // Head: 83.78% // Decreases project coverage by -1.37% ⚠️

Coverage data is based on head (1c01885) compared to base (e50db3e).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 1c01885 differs from pull request most recent head ceb8bc9. Consider uploading reports for the commit ceb8bc9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1419      +/-   ##
==========================================
- Coverage   85.16%   83.78%   -1.38%     
==========================================
  Files          19       17       -2     
  Lines        3620     3417     -203     
==========================================
- Hits         3083     2863     -220     
- Misses        459      469      +10     
- Partials       78       85       +7     
Impacted Files Coverage Δ
gen/gen.go 93.51% <100.00%> (+0.03%) ⬆️
parser.go 94.43% <100.00%> (+0.13%) ⬆️
types.go 88.88% <0.00%> (-11.12%) ⬇️
packages.go 85.45% <0.00%> (-3.64%) ⬇️
operation.go 95.97% <0.00%> (-0.29%) ⬇️
generics.go
utils_go18.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 9a4fa5d into master Dec 12, 2022
@ubogdan ubogdan deleted the fix-1414 branch December 12, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants