Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements: search imports sequencely, till find the type. #1374

Merged
merged 4 commits into from Nov 2, 2022

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Oct 31, 2022

Describe the PR
Enhancements:
search imports sequencely, till find the type.
consider every import mode ,such as alias,underline, dot.
if a model is imported from an external by mode dot, also load it.

Relation issue
#1373

consider every import mode ,such as alias,underline, dot.
a model imported from an external by mode dot.

Signed-off-by: sdghchj <sdghchj@qq.com>
Signed-off-by: sdghchj <sdghchj@qq.com>
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 95.43% // Head: 95.71% // Increases project coverage by +0.28% 🎉

Coverage data is based on head (5e958cc) compared to base (07690e9).
Patch coverage: 98.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
+ Coverage   95.43%   95.71%   +0.28%     
==========================================
  Files          14       14              
  Lines        2824     2826       +2     
==========================================
+ Hits         2695     2705      +10     
+ Misses         71       66       -5     
+ Partials       58       55       -3     
Impacted Files Coverage Δ
packages.go 92.43% <98.11%> (+3.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: sdghchj <sdghchj@qq.com>
@sdghchj sdghchj requested a review from ubogdan November 1, 2022 06:21
@sdghchj sdghchj merged commit eaed517 into master Nov 2, 2022
@sdghchj sdghchj deleted the search-every-possible-import-package branch November 2, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants