Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for nil otherTypeDef #1372

Merged
merged 3 commits into from Oct 30, 2022
Merged

Add check for nil otherTypeDef #1372

merged 3 commits into from Oct 30, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 29, 2022

Relation issue
e.g. https://github.com/swaggo/swag/pull/118/files

This PR solve the problem

@sdghchj
Copy link
Member

sdghchj commented Oct 29, 2022

Sorry, I introduced this bug
pkgDefs.uniqueDefinitions[fullName] needs staying nil as a mark that the same fullName exists, and will be removed finally.

packages.go Outdated Show resolved Hide resolved
Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Base: 95.70% // Head: 95.43% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (6e0677a) compared to base (38b5f15).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
- Coverage   95.70%   95.43%   -0.28%     
==========================================
  Files          14       14              
  Lines        2818     2824       +6     
==========================================
- Hits         2697     2695       -2     
- Misses         67       71       +4     
- Partials       54       58       +4     
Impacted Files Coverage Δ
packages.go 88.98% <0.00%> (-3.20%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

packages.go Outdated Show resolved Hide resolved
packages.go Outdated Show resolved Hide resolved
Copy link
Member

@sdghchj sdghchj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you!

@sdghchj sdghchj merged commit 07690e9 into swaggo:master Oct 30, 2022
@ghost ghost deleted the fix/issue-1368 branch October 30, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant