Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make swagger comments more readable for go doc #1366

Merged
merged 4 commits into from Oct 28, 2022
Merged

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Oct 27, 2022

Relation issue
#1364

Signed-off-by: sdghchj <sdghchj@qq.com>
Signed-off-by: sdghchj <sdghchj@qq.com>
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 95.70% // Head: 95.70% // No change to project coverage 👍

Coverage data is based on head (4e16c82) compared to base (0da94ff).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1366   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files          14       14           
  Lines        2818     2818           
=======================================
  Hits         2697     2697           
  Misses         67       67           
  Partials       54       54           
Impacted Files Coverage Δ
formatter.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ubogdan
ubogdan previously approved these changes Oct 27, 2022
@ubogdan
Copy link
Contributor

ubogdan commented Oct 27, 2022

@sdghchj Please update examples with new format so we can see them on pkg.go.dev 😄

Signed-off-by: sdghchj <sdghchj@qq.com>
@sdghchj
Copy link
Member Author

sdghchj commented Oct 28, 2022

@ubogdan
updated

@sdghchj sdghchj closed this Oct 28, 2022
@sdghchj sdghchj reopened this Oct 28, 2022
Signed-off-by: sdghchj <sdghchj@qq.com>
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 38b5f15 into master Oct 28, 2022
@ubogdan ubogdan deleted the friendly-swagger-doc branch October 28, 2022 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants