refactor: move from io/ioutil to io and os packages #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The io/ioutil package has been deprecated as of Go 1.16 [1]. This commit replaces the existing io/ioutil functions with their new definitions in io and os packages. [1]: https://golang.org/doc/go1.16#ioutil Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Codecov ReportBase: 95.64% // Head: 95.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1334 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 14 14
Lines 2871 2871
=======================================
Hits 2746 2746
Misses 70 70
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@Juneezee Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
The
io/ioutilpackage has been deprecated in Go 1.16 (See https://pkg.go.dev/io/ioutil). Since we have dropped support for Go 1.15 and lower (#1331), we can replace the existingio/ioutilfunctions with their new definitions inioandospackages.ioutil.Discard=>io.Discardioutil.NopCloser=>io.NopCloserioutil.ReadAll=>io.ReadAllioutil.ReadDir=>os.ReadDir(returns a slice ofos.DirEntryrather than a slice offs.FileInfo, this may improve performance in some cases asos.ReadDiris more efficient [1])ioutil.ReadFile=>os.ReadFileioutil.TempDir=>os.MkdirTempioutil.TempFile=>os.CreateTempioutil.WriteFile=>os.WriteFileRelation issue
Additional context
Add any other context about the problem here.