refactor func splitStructName #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 30, 2022 11:23
Signed-off-by: sdghchj <chengjin@cmiot.chinamobile.com>
Signed-off-by: sdghchj <chengjin@cmiot.chinamobile.com>
Signed-off-by: sdghchj <chengjin@cmiot.chinamobile.com>
Codecov Report
@@ Coverage Diff @@
## master #1313 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 14 14
Lines 2851 2851
=======================================
Hits 2726 2726
Misses 70 70
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ubogdan
reviewed
Aug 30, 2022
| lastParam = "" | ||
| depth := 0 | ||
| genericParams = strings.FieldsFunc(genericParams[1], func(r rune) bool { | ||
| if r == '[' { |
There was a problem hiding this comment.
I think it's more elegant with a switch case
switch r {
case '[':
depth++
case ']':
depth--
case ',':
if depth == 0 {
return true
}
default:
return false
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just reimplement the func splitStructName with std functions in library
strings