Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic generics support #1225

Merged
merged 3 commits into from Jun 16, 2022
Merged

feat: add basic generics support #1225

merged 3 commits into from Jun 16, 2022

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jun 11, 2022

Describe the PR
This is a competition for #1194.

Relation issue
#1170 #1194

Additional context
Finish contribution in order to speed up things.

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #1225 (adf24b0) into master (67cb768) will decrease coverage by 0.15%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master    #1225      +/-   ##
==========================================
- Coverage   94.96%   94.80%   -0.16%     
==========================================
  Files          12       14       +2     
  Lines        2520     2600      +80     
==========================================
+ Hits         2393     2465      +72     
- Misses         69       74       +5     
- Partials       58       61       +3     
Impacted Files Coverage Δ
generics_other.go 50.00% <50.00%> (ø)
packages.go 87.30% <80.00%> (+0.56%) ⬆️
generics.go 90.47% <90.47%> (ø)
operation.go 96.66% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67cb768...adf24b0. Read the comment docs.

@ubogdan
Copy link
Contributor Author

ubogdan commented Jun 11, 2022

Unfortunately, this implementation doesn't produce a valid OAS2 definition.

invalid-definition

@ubogdan
Copy link
Contributor Author

ubogdan commented Jun 16, 2022

LGTM 😄

@ubogdan ubogdan merged commit ff41d9c into master Jun 16, 2022
@ubogdan ubogdan deleted the basic-generics-support branch June 16, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant