Implement error (and any) like interface #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
- Coverage 95.02% 94.96% -0.07%
==========================================
Files 12 12
Lines 2515 2524 +9
==========================================
+ Hits 2390 2397 +7
- Misses 68 69 +1
- Partials 57 58 +1
Continue to review full report at Codecov.
|
ubogdan
requested changes
May 24, 2022
Comment on lines
+871
to
+873
| if IsInterfaceLike(typeName) { | ||
| return &spec.Schema{}, nil | ||
| } |
There was a problem hiding this comment.
We need to cover this with unit tests.
There was a problem hiding this comment.
It should already be covered by TestGen_ErrorAndInterface and TestIsInterfaceLike but I can recheck.
There was a problem hiding this comment.
I added a test similar to TestGen_ErrorAndInterface based on testdata in the root package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This manage error and any like interface.
Previously, any would result in a primitive type
anywhich seem not valid in swagger definition.This basically, set an empty definition like for
interface{}previously foranyanderrortypes.Relation issue
erroras a Primitive Type #1188Additional context
This fix cases when you cannot override with tag
swaggertypein case the struct is from an external dependency.Previously this case need to redefine the struct locally to override the field type but can be cumbersome in case of deeply nested struct and It is also not possible to override go types with .swaggo file.
I first try to implement like suggested in this comment but after reviewing some cases (like in the testdata test) this feel better and more logical to consider error (and any) like interface. Let me know if it doesn't fit you.