Fix/array enum varnames in arrays #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1187 +/- ##
==========================================
- Coverage 95.02% 94.96% -0.07%
==========================================
Files 12 12
Lines 2515 2520 +5
==========================================
+ Hits 2390 2393 +3
- Misses 68 69 +1
- Partials 57 58 +1
Continue to review full report at Codecov.
|
… into fix/array_enum_varnames
|
@Skisocks Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Fix the how x-enum-varnames are formatted when in an array of enums.
Relation issue
Issue 1186
Additional context
Not sure whether all extensions in arrays should be handled like this so I've just limited it to x-enum-varnames. Added fields to expected json to confirm this.