Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve code quality #1184

Merged
merged 13 commits into from Apr 26, 2022
Merged

chore: improve code quality #1184

merged 13 commits into from Apr 26, 2022

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Apr 22, 2022

Describe the PR
Improve code quality

Relation issue
None

Additional context
None

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1184 (6619b51) into master (d209f71) will increase coverage by 0.31%.
The diff coverage is 98.55%.

❗ Current head 6619b51 differs from pull request most recent head 1e188f7. Consider uploading reports for the commit 1e188f7 to get more accurate results

@@            Coverage Diff             @@
##           master    #1184      +/-   ##
==========================================
+ Coverage   94.71%   95.03%   +0.31%     
==========================================
  Files          10       10              
  Lines        2460     2557      +97     
==========================================
+ Hits         2330     2430     +100     
- Misses         68       69       +1     
+ Partials       62       58       -4     
Impacted Files Coverage Δ
schema.go 100.00% <ø> (ø)
swagger.go 100.00% <ø> (ø)
packages.go 85.47% <91.30%> (-0.41%) ⬇️
parser.go 92.87% <98.38%> (+0.46%) ⬆️
field_parser.go 99.11% <98.71%> (+0.29%) ⬆️
formatter.go 100.00% <100.00%> (ø)
gen/gen.go 93.26% <100.00%> (-0.07%) ⬇️
operation.go 96.35% <100.00%> (+0.33%) ⬆️
spec.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d209f71...1e188f7. Read the comment docs.

@ubogdan ubogdan changed the title chore: lining spec.go chore: improve code quality Apr 25, 2022
@ubogdan ubogdan merged commit 636f456 into master Apr 26, 2022
@ubogdan ubogdan deleted the linting branch April 26, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant