[security] feature add or-option #1151
Conversation
|
Please fix the unit tests to go forward with a code review. |
Hey ubogdan thx for your res. |
operation.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (operation *Operation) ProcessSecurityOption(securityOption string, securityMap SecurityMap) { |
There was a problem hiding this comment.
We don't need additional export. Even make this a private function even move the code inside the for loop.
operation.go
Outdated
| @@ -629,30 +629,38 @@ func (operation *Operation) ParseRouterComment(commentLine string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| type SecurityMap map[string][]string | |||
There was a problem hiding this comment.
Useless definition. Please remove.
|
unit tests are failing... |
|
I'm having file-permission errors running tests locally. Is it a git convention that tests on the repo only run when someone approves the workflow? |
|
@Lehp Workflow approval is required because you are first time contributor on this repo. |
Codecov Report
@@ Coverage Diff @@
## master #1151 +/- ##
==========================================
+ Coverage 94.73% 94.76% +0.02%
==========================================
Files 10 10
Lines 2433 2443 +10
==========================================
+ Hits 2305 2315 +10
Misses 67 67
Partials 61 61
Continue to review full report at Codecov.
|
|
@ubogdan do you know why this tests fails locally for me? |
|
See notes : |
|
I just realized the README.nd wasn't updated so that the users can benefit from this feature. Would you mind creating another PR with the documentation update ?. |
Describe the PR
Feature to generate OR-security option for swagger files.
Relation issue
e.g. https://github.com/swaggo/swag/pull/118/files
Additional context
Sorry for not waiting for any approval Was watching at the source code and almost accidentally coded this.
I desperately need this function to make this repo useful for my company.