Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Linter fails (#1136) #1137

Merged
merged 3 commits into from Feb 17, 2022
Merged

Fix: Linter fails (#1136) #1137

merged 3 commits into from Feb 17, 2022

Conversation

pilinux
Copy link
Contributor

@pilinux pilinux commented Feb 13, 2022

Describe the PR
Fix: Linter fails (#1136)

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1137 (f85d85b) into master (1a0a57a) will not change coverage.
The diff coverage is n/a.

❗ Current head f85d85b differs from pull request most recent head 7ddb28e. Consider uploading reports for the commit 7ddb28e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1137   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files          10       10           
  Lines        2433     2433           
=======================================
  Hits         2305     2305           
  Misses         67       67           
  Partials       61       61           
Impacted Files Coverage Δ
gen/gen.go 93.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a0a57a...7ddb28e. Read the comment docs.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the changes regarding the default swagger instance name.

swagger.go Outdated Show resolved Hide resolved
@ubogdan
Copy link
Contributor

ubogdan commented Feb 17, 2022

Please update the doc of all examples with the latest "genetator version"

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean now. Please update according to the changes and regenerate docs once again.
Thanks for your patience.

gen/gen.go Show resolved Hide resolved
gen/gen.go Outdated Show resolved Hide resolved
@ubogdan
Copy link
Contributor

ubogdan commented Feb 17, 2022

@pilinux it looks I'm not in very good shape this week. So please bear with me.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit cd97e7f into swaggo:master Feb 17, 2022
@ubogdan
Copy link
Contributor

ubogdan commented Feb 17, 2022

@pilinux Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants