Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renaming SwaggerInfo causes a breaking change #1127

Merged
merged 1 commit into from Feb 6, 2022

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Feb 5, 2022

Describe the PR

  • fix breaking change introduced by the generation of multiple api documents in the same doc folder.

Relation issue
#1126

Additional context
None.

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #1127 (147f15a) into master (e969efb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1127   +/-   ##
=======================================
  Coverage   94.84%   94.84%           
=======================================
  Files          10       10           
  Lines        2404     2404           
=======================================
  Hits         2280     2280           
  Misses         65       65           
  Partials       59       59           
Impacted Files Coverage Δ
gen/gen.go 93.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e969efb...147f15a. Read the comment docs.

@ubogdan ubogdan changed the title fix: renaming SwaggerInfo compatibility issue fix: renaming SwaggerInfo causes a breaking change Feb 5, 2022
@ubogdan
Copy link
Contributor Author

ubogdan commented Feb 5, 2022

@easonlin404 Not sure if we should to release 1.8.0 only with this patch or we should wait for other contributions.

@ubogdan
Copy link
Contributor Author

ubogdan commented Feb 5, 2022

Alternatively, we can release v1.7.9p1 only with this patch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant