Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Generated file name from instanceName #1112

Merged
merged 4 commits into from Jan 28, 2022
Merged

Feature: Generated file name from instanceName #1112

merged 4 commits into from Jan 28, 2022

Conversation

Ferrany1
Copy link
Contributor

Describe the PR
Feature: Generated file name from instanceName

@ubogdan
Copy link
Contributor

ubogdan commented Jan 26, 2022

@Ferrany1, is this change related to any open issues?

@Ferrany1
Copy link
Contributor Author

@ubogdan no, do I need to create one?

Fix: delim addition to file name if instance name not empty
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #1112 (6a7cabf) into master (32f02b9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
+ Coverage   94.59%   94.61%   +0.02%     
==========================================
  Files           9        9              
  Lines        2370     2379       +9     
==========================================
+ Hits         2242     2251       +9     
  Misses         67       67              
  Partials       61       61              
Impacted Files Coverage Δ
gen/gen.go 93.33% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f02b9...6a7cabf. Read the comment docs.

Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit cae7467 into swaggo:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants