fix: split extensions param respecting open/close brackets #1107
Conversation
|
It this PR related to any open issue? |
|
No. I needed to use extensions params and had problems with texts containing comma and then opened this PR. |
|
@ubogdan could you please approve running the workflows? |
It seems I missed this notification. |
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
+ Coverage 94.59% 94.73% +0.13%
==========================================
Files 9 10 +1
Lines 2370 2433 +63
==========================================
+ Hits 2242 2305 +63
Misses 67 67
Partials 61 61
Continue to review full report at Codecov.
|
field_parser.go
Outdated
| @@ -207,7 +207,9 @@ func (ps *tagBaseFieldParser) ComplementSchema(schema *spec.Schema) error { | |||
| extensionsTag := ps.tag.Get(extensionsTag) | |||
| if extensionsTag != "" { | |||
| structField.extensions = map[string]interface{}{} | |||
| extensionsTag := strings.ReplaceAll(extensionsTag, `,,`, `{{escape-comma}}`) | |||
| for _, val := range strings.Split(extensionsTag, ",") { | |||
There was a problem hiding this comment.
Adding double-quoted is an ugly hack.
The solution is to line instead of split by comma by respection open/close brackets.
There was a problem hiding this comment.
I agree. double-comma was a quick fix. I'll try the solution you suggested
There was a problem hiding this comment.
Changed as suggested
helder-jaspion
changed the title
|
@helder-jaspion Thanks for your contribution! |
Describe the PR
split extensions param respecting open/close brackets
// @Param range query string true "Range" default([0, 9]) extensions(x-example=[0,9])Relation issue
None.
Additional context
When using extensions param with text containing comma the extensions were getting splited wrong.