feat: add generation of type description to schema (#708) #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
+ Coverage 94.47% 94.59% +0.12%
==========================================
Files 9 9
Lines 2316 2370 +54
==========================================
+ Hits 2188 2242 +54
Misses 67 67
Partials 61 61
Continue to review full report at Codecov.
|
|
@KuboOrk, would you mind adding a test case so code coverage will get back to positive? |
ubogdan
requested changes
Jan 20, 2022
- moved "if" statement out of the method - renamed fillDefinition → fillDefinitionDescription
- increase code readability by union conditions - moved result variable declaration inside function body
|
@KuboOrk Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Added "description" field generation for swagger scheme from struct documentation
Relation issue
#708
Additional context
None