Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: field tags constants #1088

Merged
merged 1 commit into from Dec 23, 2021
Merged

chore: field tags constants #1088

merged 1 commit into from Dec 23, 2021

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Dec 23, 2021

Describe the PR
reduce the number of hardcoded tags.

Relation issue
None

Additional context
None

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1088 (f3b77ab) into master (557e1c6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1088   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files           9        9           
  Lines        2316     2316           
=======================================
  Hits         2188     2188           
  Misses         67       67           
  Partials       61       61           
Impacted Files Coverage Δ
operation.go 95.86% <ø> (ø)
field_parser.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557e1c6...f3b77ab. Read the comment docs.

@ubogdan ubogdan merged commit a8ef569 into master Dec 23, 2021
@ubogdan ubogdan deleted the replace_constants branch December 23, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant