Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new option for urls.primaryName #9825

Open
glowcloud opened this issue Apr 15, 2024 · 1 comment
Open

Create a new option for urls.primaryName #9825

glowcloud opened this issue Apr 15, 2024 · 1 comment

Comments

@glowcloud
Copy link
Contributor

As we're moving to merging options with dots in names like syntaxHighlight.theme into parent settings like syntaxHighlight, we have an issue with urls.primaryName. The urls setting is an array and we can set the primaryName property to it but the information gets lost after using deepExtend. As such, we're trying to compensate for it by making an exception while merging, in: #9824

Instead of doing that, we could simply create a new option that we wouldn't merge into the urls array, while also supporting the previous option. For example, we could have urlsPrimaryName and if we specify urls.primaryName instead, simply set the value from it to urlsPrimaryName and delete urls.primaryName.

@char0n
Copy link
Member

char0n commented Apr 18, 2024

This needs to be addressed in next major release when we can do breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants