You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As we're moving to merging options with dots in names like syntaxHighlight.theme into parent settings like syntaxHighlight, we have an issue with urls.primaryName. The urls setting is an array and we can set the primaryName property to it but the information gets lost after using deepExtend. As such, we're trying to compensate for it by making an exception while merging, in: #9824
Instead of doing that, we could simply create a new option that we wouldn't merge into the urls array, while also supporting the previous option. For example, we could have urlsPrimaryName and if we specify urls.primaryName instead, simply set the value from it to urlsPrimaryName and delete urls.primaryName.
The text was updated successfully, but these errors were encountered:
As we're moving to merging options with dots in names like
syntaxHighlight.theme
into parent settings likesyntaxHighlight
, we have an issue withurls.primaryName
. Theurls
setting is an array and we can set theprimaryName
property to it but the information gets lost after usingdeepExtend
. As such, we're trying to compensate for it by making an exception while merging, in: #9824Instead of doing that, we could simply create a new option that we wouldn't merge into the
urls
array, while also supporting the previous option. For example, we could haveurlsPrimaryName
and if we specifyurls.primaryName
instead, simply set the value from it tourlsPrimaryName
and deleteurls.primaryName
.The text was updated successfully, but these errors were encountered: