-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add aria label to select element for content types #7133
fix: add aria label to select element for content types #7133
Conversation
…airs/swagger-ui into bug/add-aria-label-to-select
…a-label-to-select fix: add aria label to select element for content types
Merge from upstream
@gileswells Thanks for the PR! It looks good. If you can rebase, or better yet given asynchronous timing, allow maintainers to make edits to this PR, I will be able to merge this PR. |
@tim-lai I thought I had checked that box. I pulled master back to our fork. If there's something else you need or if there's a better way to submit a PR I'll keep an eye out here but I'm also available on the IRC channel if that's easier. |
@gileswells Thanks. I saw your reply right after I merged a different PR. I'm still not able to update branch for this PR though. Can you rebase one more time, and I'll hold until I see this one updated. |
@tim-lai sorry missed your comment. This is merged again for you. |
@gileswells PR merged! Thanks again! |
The goal here is to add aria-labels to the dropdowns to provide people using assistive tech like screen readers with more information about the page / part of the page they're interacting with.
Description
We added an
ariaLabel
prop to the ContentType component and then updated instances where<ContentType />
is used to include the new prop.Motivation and Context
At the VA we have always have a focus on accessibility and SwaggerUI has been on our radar as something we use that could receive some accessibility love. There isn't any specific issue to link on this repo but there have been past accessibility issues that we hope overlap.
How Has This Been Tested?
We've tested this using VoiceOver on Mac and JAWS for Windows. With there being no visual changes for this we didn't see any regressions elsewhere in the project.
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests