Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate nullable #6928

Merged
merged 2 commits into from Feb 11, 2021
Merged

Conversation

mathis-m
Copy link
Contributor

respect nullable keyword

Description

If value === null and nullable then no validation error.

openapi: 3.0.1
info:
  title: v1
  version: v1
servers:
  - url: 'http://localhost:62242'
paths:
  /nullable:
    get:
      parameters:
        - name: "someNull"
          in: query
          required: false
          schema:
            type: number
            format: Int32
            nullable: true
          example: null
      responses:
        '200':
          description: Success
          content:
            text/json:
              schema:
                type: string
              example: "123"
            application/json:
              schema:
                type: string
              examples: 
                x:
                  value: "132"

Motivation and Context

Fixes #6927

How Has This Been Tested?

browser

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

mathis-m and others added 2 commits February 10, 2021 21:36
Signed-off-by: mathis-m <mathis.michel@outlook.de>
@tim-lai tim-lai merged commit a2a561e into swagger-api:master Feb 11, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Feb 11, 2021

@mathis-m PR merged! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation error if an empty integer parameter is passed that is not mandatory
2 participants