Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft/value retainer sample gen #6920

Merged
merged 4 commits into from Feb 11, 2021

Conversation

mathis-m
Copy link
Contributor

@mathis-m mathis-m commented Feb 9, 2021

Description

This will fix issues with escaping string type // number examples in case of multiple examples.
Because it now relies on sample-gen, instead of passing raw examples to retainer now the samplegen example values are passed instead.
I also fixed a bug where multiple example had same value and it selected every time the first one if it was change to some of the example with same value, never the less which one was selected.

Motivation and Context

Fixes #6918
Part of fixing #6470

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
Signed-off-by: mathis-m <mathis.michel@outlook.de>
@tim-lai tim-lai merged commit fad81f8 into swagger-api:master Feb 11, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Feb 11, 2021

@mathis-m PR merged! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple example rendering wrong escaped => "123" is 123
2 participants