Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sample-gen multipart and form media-type #6874

Merged
merged 2 commits into from Feb 3, 2021

Conversation

mathis-m
Copy link
Contributor

@mathis-m mathis-m commented Jan 28, 2021

application/x-www-form-urlencoded || multipart/ initial value should rely on sample gen in case it will harvest schema information.

Description

Part of lager refactor issue #6470

Changes:

  • Example from sample gen instead of only default and example in case of example | default | 1 enum value

Motivation and Context

Fixes #6621 because the initial value was manually retrieved from the spec. With switching to sample gen fn the case stated in the issue is already implemented. (?url=https://gist.githubusercontent.com/mathis-m/388f6772747dfeb8a0092eac69cfd008/raw/711e6f787da10f1ae57873749f6826f9b3c6be60/Pqo45ggmbT.txt)

How Has This Been Tested?

not - but I don't think we need any test for this because we now use existing logic.

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@mathis-m mathis-m force-pushed the ft/multi-form-sample-gen branch 2 times, most recently from 9fd1eed to 0668a47 Compare January 28, 2021 02:48
@mathis-m mathis-m marked this pull request as draft January 28, 2021 19:19
@mathis-m mathis-m force-pushed the ft/multi-form-sample-gen branch 3 times, most recently from 6f00f75 to 921d087 Compare January 28, 2021 23:06
application/x-www-form-urlencoded || **multipart/** initial value should rely on sample gen

Signed-off-by: mathis-m <mathis.michel@outlook.de>
@mathis-m mathis-m marked this pull request as ready for review January 29, 2021 00:15
@mathis-m mathis-m changed the title feat: sample-gen mulit and form media-type feat: sample-gen multipart and form media-type Jan 29, 2021
@tim-lai tim-lai merged commit 8ed6c34 into swagger-api:master Feb 3, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Feb 3, 2021

@mathis-m PR merged! Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's impossible to send request with selected value by default
2 participants