Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/6508 fix json response highlighting #6871

Merged

Conversation

nico-abram
Copy link
Contributor

@nico-abram nico-abram commented Jan 27, 2021

Use the language prop for react-syntax-highlighter for JSON response bodies

Description

I added a language prop to the highlighter wrapper, and propagated it. Then I just passed it for JSON response bodies

Motivation and Context

Fixes #6508

How Has This Been Tested?

I copied some of the highlighter code to a react playground, this seemed to fix it. Have not tested the fix by building all of swagger-ui as I do not have a dev environment for it

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai merged commit 13fea13 into swagger-api:master Feb 3, 2021
@tim-lai
Copy link
Contributor

tim-lai commented Feb 3, 2021

@nico-abram PR merged! Thanks for the contribution fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax highlighting is broken in server response
2 participants