Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump js-yaml to v4.0.0 #6804

Closed
wants to merge 1 commit into from

Conversation

tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Jan 8, 2021

Description

  • update js-yaml to v4.0.0
  • update instances of .safeLoad() to .load()

Motivation and Context

update dependencies

How Has This Been Tested?

Note, this change currently breaks Cypress test for bugs/5043, which includes an external $ref. Needs additional investigation.

using 'npm link' alongside changes introduced in swagger-js swagger-api/swagger-js#1867 does not resolve the issue.

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

char0n added a commit that referenced this pull request Aug 6, 2021
char0n added a commit to swagger-api/swagger-editor that referenced this pull request Aug 6, 2021
@char0n char0n closed this in #7455 Aug 9, 2021
char0n added a commit that referenced this pull request Aug 9, 2021
char0n added a commit to swagger-api/swagger-editor that referenced this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant