Skip to content

Accidentally removed "test" scope from "slf4j-simple"? #1753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christopher-cudennec opened this issue Jun 17, 2022 · 1 comment · Fixed by #1754
Closed

Accidentally removed "test" scope from "slf4j-simple"? #1753

christopher-cudennec opened this issue Jun 17, 2022 · 1 comment · Fixed by #1754

Comments

@christopher-cudennec
Copy link

Hey everyone!

I just had to fix an update to your latest version in our open source library sda-dropwizard-commons: SDA-SE/sda-dropwizard-commons#1663

The issue was that you removed the "test" scope from dependency "slf4j-simple" which I guess happened by accident, right? Could you double check your changes and add the scope again?

Here's the file:
https://github.com/swagger-api/swagger-parser/blob/v2.1.0/modules/swagger-parser-v3/pom.xml

Here's the commit that removed the scope:
3ac5401#diff-39aeb849fc2cee74ac7373cabe6e5b9c3b40174d433ca537067c6ac44e5841bf

Thanks!

Christopher

frantuma added a commit that referenced this issue Jun 17, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fixes #1753
@frantuma
Copy link
Member

Thanks for reporting this! It has been indeed an accident gone unnoticed, fixed in #1754 and released 2.1.1 with the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants