Bug/1562 path body #1564
Merged
Bug/1562 path body #1564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- OData services often use dots (.) to separate long names in their path, so let's use them to improve camel-case flattened names.
ivy-rew
force-pushed
the
bug/1562-pathBody
branch
from
7133683
to
0fb0cff
Compare
gracekarina
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry to raise your attention on bug #1562 again. But I found that my initial contribution still has some shortcomings if used with OData services, that have '.' separated path names. And also with the caml-case writing option.
here's a sample of such path separators in action https://petstore.swagger.io/?url=https://raw.githubusercontent.com/oasis-tcs/odata-openapi/master/examples/TripPin.openapi3.json
/People('{UserName}')/Microsoft.OData.SampleService.Models.TripPin.ShareTrip