fix handling of relative references

[johanra]

This PR includes a fix & testcase for this [issue] (#1459)

[gracekarina]

thanks @johanra

[olesiathoms-wk]

@gracekarina Do you know when this fix will be released?

[slimane-deb]

@johanra Looking forward to it. Thumbs up

[feliperuiz]

I'm sorry for asking a long time after this was merged, but wouldn't this make it a relative ref instead of an absolute one? Wouldn't it need to start with a <scheme>: to be considered absolute?

[johanra]

You are right this is not correct.
My intention was to have the isAbsoluteRef method match anything that is not relative.
The code should then look like this:
protected boolean isAbsoluteRef(String ref) { return !ref.startsWith("."); ​}

protected String computeRelativeRef(String ref, String prefix) {
if(ref.startsWith("./")) {
​return ref;
​}
int iIdxOfSlash = prefix.lastIndexOf('/');
if(iIdxOfSlash != -1) {
return prefix.substring(0, iIdxOfSlash+1) + ref;
}
return prefix + ref;
​}