external $ref without / caused exception #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External refs did not work at all on windows.
|
Hi, @kaewberg thanks for the PR, can you please add the spec that is causing this error?, or even better if you can add a test to the PR will be great!. Thanks |
# Conflicts: # modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/processors/ExternalRefProcessor.java
|
thanks @kaewberg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1543
... subtring(0, indexOf ... causes StringIndexOutOfBounds if the char searched for is missing. This meant that refs like $ref("another_file.json#/thing") could not be parsed. In addition, File.sparatorChar was used to find separators in directory part of ref, causing most every parsing attempt to fail on windows. We should probably require "/" to be used as path separator.