Fix the problem that the content of extensions cannot be parsed #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This problem will appear in Json format. |
|
Hi, thanks for the PR, may you please commit the specific change you are making, and a specific test to corroborate the fix, thanks. |
|
The new logic is that after the original extensions are parsed, if the content is not parsed, try to parse it again in Json format. I have added the unit test. |
|
thanks @Bulls1986 |
|
How to fix it in 2.0.0-rc1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,bro.It seems that the content of extensions under the node is not parsed here,resulting in the extensions content of all nodes not being parsed,so here is added to take the extensions node and parse the content under the node.