-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPIDeserializer.getSchema: Handle "enum" correctly when schema type is "array" or "object" #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid to resolve openAPI if it is null Fixes swagger-api#1455
…pe is "array" or "object"
thanks @kerrykimbrough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1419
For a schema of type
array
, each element of theenum
array must be an array. But an enumerated array may contain values that don't have a native Java representation (for example, "object" values). Therefore, an enumerated array element is represented by anArrayNode
value, which contains the fully-parsed representation of the enumerated value.Similarly, for a schema of type
object
, each element of theenum
array must be an object. But an object value doesn't have a well-defined native Java representation. Therefore, an enumerated object element is represented by anObjectNode
.But in any case, a null element of an
enum
array is represented by a Javanull
value, which is consistent withenum
handling for all other schema types.