bugfix(mermaid): circumvents mermaid edge naming ambiguities

[sverweij]

Description

• makes the 'minified' node names in generated mermaid uppercase

Motivation and Context

There's some interesting edge cases in the mermaid flowchart language. These two seemingly equal flowcharts render differently. Reason is that o--> is an arrow shape. Two ways to fix it

• use spaces (o --> a) -> this would make the generated .mmd larger, so we'll bump into mermaid's maximum input limit faster
• don't use the characters that manifest the ambiguity (o and x). Easiest way to accomplish that is to uppercase the 'minified' node names.

flowchart LR
o
a
o-->a

flowchart LR
o
a
o-->a

flowchart LR
O
A
O-->A

flowchart LR
O
A
O-->A

How Has This Been Tested?

• green ci
• updated automated tests
• some manual testing

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Documentation only change
• Refactor (non-breaking change which fixes an issue without changing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• 📖

  • My change doesn't require a documentation update, or ...
  • it does and I have updated it

• ⚖️

  • The contribution will be subject to The MIT license, and I'm OK with that.
  • The contribution is my own original work.
  • I am ok with the stuff in CONTRIBUTING.md.

[MH4GF]

Wow this is an interesting edge cases😳 Thanks for fix it!