Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(report): improves instability alignment in metrics reporter #707

Merged
merged 1 commit into from Dec 24, 2022

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Dec 24, 2022

Description

  • reserves an extra character of room for displaying metrics in the metrics reporter
  • also removes a superfluous toString statement from the same

Motivation and Context

Some locales put a space between the number and the percentage sign. The max width of the I column didn't account for that - resulting in misalignment between 3 and < 3 number percentages:

100 %
90 %
 1 %
100 %

After the fix it looks normal in these locales again:

100 %
 90 %
  1 %
100 %

How Has This Been Tested?

  • green ci
  • adapted unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 馃摉

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • 鈿栵笍

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

some locales put a space between the number and the percentage sign. The max width of the I column didn't account for that - resulting in misalignment between 3 and < 3 number percentages
@sverweij sverweij merged commit fc0404c into develop Dec 24, 2022
@sverweij sverweij deleted the refactor/improve-metrics-formatting branch December 24, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant