Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(init-config): removes superfluous function; touches up the typing a bit #706

Merged
merged 1 commit into from Dec 23, 2022

Conversation

sverweij
Copy link
Owner

Description

  • renames the inquirers-validators.js to validators.js (we're not using inquirer anymore and for the validators it's not relevant in any case
  • removes a function in that file that wasn't used (other than in a test - which got removed too)
  • corrects spelling of some functions & variable names
  • corrects/ clarifies some typings in the init-config code (it's not perfect yet, but better than it was)
  • removes attributes from IInitOptions interface as they weren't used anymore + added the jsConfig ones

Motivation and Context

  • should ease maintenance a bit
  • dead code will rot ...

How Has This Been Tested?

  • green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the refactor/init-config-touch-up branch from 82e9f0f to 217b486 Compare December 23, 2022 21:15
@sverweij sverweij merged commit 8d34441 into develop Dec 23, 2022
@sverweij sverweij deleted the refactor/init-config-touch-up branch December 23, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant