Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(mermaid): makes nodes without a name render as well #705

Merged
merged 1 commit into from Dec 23, 2022

Conversation

sverweij
Copy link
Owner

Description

  • if a node has no name, label it " " in stead of "" the latter of which mermaid refuses to render

Motivation and Context

These nodes occur when running dependency-cruiser with a --collapse pattern. This is a temporary band-aid until we've found a way to have the mermaid reporter output these more elegantly.

How Has This Been Tested?

  • green ci

Screenshots

coming up

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 馃摉

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • 鈿栵笍

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the bugfix/mermaid-make-label-less-nodes-render branch from 3fc6295 to 5f094bb Compare December 23, 2022 17:07
@sverweij sverweij merged commit c482c0d into develop Dec 23, 2022
@sverweij sverweij deleted the bugfix/mermaid-make-label-less-nodes-render branch December 23, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant