New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: bans parameter reassignments #700

Merged

sverweij merged 1 commit into develop from refactor/ban-parameter-re-assign

Dec 21, 2022

Owner

sverweij commented Dec 21, 2022 •

edited

Description

removes the last parameter reassignments from the code

Motivation and Context

makes the concerned code easier to understand + less easy to introduce subtle bugs

How Has This Been Tested?

green ci

Types of changes

Bug fix (non-breaking change which fixes an issue)
Documentation only change
Refactor (non-breaking change which fixes an issue without changing functionality)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist

📖
- My change doesn't require a documentation update, or ...
- it does and I have updated it
⚖️
- The contribution will be subject to The MIT license, and I'm OK with that.
- The contribution is my own original work.
- I am ok with the stuff in CONTRIBUTING.md.


          refactor: bans parameter re-assignments

0207c02

sverweij merged commit eae9d24 into develop

sverweij deleted the refactor/ban-parameter-re-assign branch

December 21, 2022 20:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment