Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(report): replaces metrics formatting code with Intl API calls #699

Merged
merged 1 commit into from Dec 21, 2022

Conversation

sverweij
Copy link
Owner

Description

  • replaces the instability metrics formatting code with an Intl function call

Motivation and Context

  • reduces maintenance
  • output is localized, so at least in theory easier to grasp for the reader

How Has This Been Tested?

  • green ci
  • adapted unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 馃摉

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • 鈿栵笍

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij merged commit 656b17f into develop Dec 21, 2022
@sverweij sverweij deleted the refactor/use-intl-for-metrics branch December 21, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant