Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(progress): adds resident set size & v8 managed memory to the performance-log #697

Merged
merged 1 commit into from Dec 19, 2022

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Dec 19, 2022

Description

  • adds resident set size (rss) and the amount of C++ objects bound to javascript objects managed by v8 ('external') to the performance-log output.

Motivation and Context

  • provides more (useful) information to analyze what dependency-cruiser is doing under the hood.

How Has This Been Tested?

  • green ci
  • updated unit test

Screenshots

after

$ node ./bin/dependency-cruise.js src bin test configs types tools --config --ignore-known
  elapsed       rss heapTotal  heapUsed  external after step...
    751ms     127Mb      84Mb      61Mb       2Mb start of node process
     11ms     128Mb      84Mb      62Mb       2Mb parsing options
     93ms     130Mb      85Mb      63Mb       2Mb cache: checking freshness
...

before

$ node ./bin/dependency-cruise.js src bin test configs types tools --config --ignore-known
  elapsed heapTotal  heapUsed after step...
    751ms      84Mb      61Mb start of node process
     11ms      84Mb      62Mb parsing options
     93ms      85Mb      64Mb cache: checking freshness
...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the feature/adds-more-memory-stats-to-performance-log branch from 3836d20 to 65eed42 Compare December 19, 2022 21:45
@sverweij sverweij merged commit f3af5df into develop Dec 19, 2022
@sverweij sverweij deleted the feature/adds-more-memory-stats-to-performance-log branch December 19, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant