Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit vulnerability because of handlebars > optimist > minimist #277

Closed
fabb opened this issue Mar 27, 2020 · 3 comments
Closed

npm audit vulnerability because of handlebars > optimist > minimist #277

fabb opened this issue Mar 27, 2020 · 3 comments
Projects

Comments

@fabb
Copy link

fabb commented Mar 27, 2020

dependency-cruiser 8.0.2 depends on handlebars@4.7.3 which depends on optimist@^0.6.1 which depends on a vulnerable version of minimist@0.0.*.

Currently there is no new handlebars version available that does not produce vulnerability errors, but there already is an open ticket for that: handlebars-lang/handlebars.js#1658

Once there is a new handlebars version available, please update the dependency on handlebars in dependency cruiser. Or, maybe even better, change the dependency right away to a semantic version range like ^4.7.3.

@sverweij
Copy link
Owner

I'm acutely aware and am following handlebars-lang/handlebars.js#1658 with interest. Might be some time it gets merged, though - the maintainer currently has more pressing things to attend to - as might I, f.tm. ...

B.t.w. on runtime dependency-cruiser does not use handlebars' cli, so strictly speaking it's a false positive (as it is for most installations using handlebars, I guess).

I have a strict policy to not trust semantic version ranges of third party packages beyond what
I can run on a ci. As in normal circumstances dependency-cruiser gets updated every one
or two weeks (which includes updates to external dependencies) and faster in case of
security issues this should be good enough to go.

@sverweij
Copy link
Owner

sverweij commented Apr 2, 2020

@fabb - I saw you helped out handlebars with a bunch of unit tests so they could move on to yargs -> thanks!!! 🙏 .

I'll release an updated dependency-cruiser tonight!

@sverweij sverweij added this to backlog in roadmap via automation Apr 2, 2020
@sverweij sverweij moved this from backlog to released in roadmap Apr 2, 2020
@sverweij
Copy link
Owner

sverweij commented Apr 2, 2020

published as 8.1.1
image

@sverweij sverweij closed this as completed Apr 4, 2020
roadmap automation moved this from released to shippable Apr 4, 2020
@sverweij sverweij moved this from shippable to released in roadmap Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
roadmap
  
released
Development

No branches or pull requests

2 participants