Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload failed with socket hang up #44

Open
Borda opened this issue Feb 3, 2021 · 10 comments
Open

upload failed with socket hang up #44

Borda opened this issue Feb 3, 2021 · 10 comments

Comments

@Borda
Copy link

Borda commented Feb 3, 2021

Hello,
we have been using this action for a few weeks and all were fine till now when I observed the following issue:

Error: request to https://uploads.github.com/repos/PyTorchLightning/pytorch-lightning/releases/37292282/assets?name=pytorch_lightning-1.1.7-py3-none-any.whl& failed, reason: socket hang up

Any idea/suggestion on what went wrong?

the trace is here - https://github.com/PyTorchLightning/pytorch-lightning/runs/1822403300?check_suite_focus=true

@svenstaro
Copy link
Owner

Pretty sure this is just a network outage. Can't really do much there except for retrying.

@Borda
Copy link
Author

Borda commented Feb 3, 2021

ok, so you suggest trying it later again?
just curious what kind of outage since it is running in GH action and release is also in Github...

@svenstaro
Copy link
Owner

Might still be that the worker's network is broken in some way.

@pranjal-joshi
Copy link
Contributor

Hello @svenstaro,

I am also facing the same issue and getting the following error. However, I may have a hint to solve this issue.
Error: request to https://uploads.github.com/repos/pranjal-joshi/Screeni-py/releases/42464624/assets?name=screenipy_macos.app& failed, reason: socket hang up

Workflow Run Log: https://github.com/pranjal-joshi/Screeni-py/runs/2508182883?check_suite_focus=true

I am using the same action to build packages for Windows, Linux and Mac. Here your action is working fine for Windows(.exe) and Linux(.bin) files because it is a single file. However, for Mac, the compiled output .app is not a file but a special directory that contains a bunch of things needed for Mac.

Can you please make sure whether this GH action is can handle the directory uploading to the release? Because actions/upload-artifact@v2 can handle this type of uploading for artifacts, so you may get an idea by going through their source if needed.

I never had hands-on experience with Mac so feel free to correct me if required.

@pranjal-joshi
Copy link
Contributor

@Borda I am having a similar issue mentioned in the above comment.
Was it just a network outage? Did you get it working back without any modifications?

@Borda
Copy link
Author

Borda commented May 5, 2021

I am having a similar issue mentioned in the above comment.
Was it just a network outage? Did you get it working back without any modifications?

Hi, we ended up switching to another solution AButler/upload-release-assets

@mcchran
Copy link

mcchran commented May 12, 2022

To make that work I just use PAT around. Not sure if relates but you can try that guys.

- uses: actions/upload-release-asset@v1.0.2
        env:
          GITHUB_TOKEN: ${{ secrets.PAT }}
        with:
          upload_url: ${{ steps.get_release.outputs.upload_url }}
          asset_path: my-app-${{ matrix.os }}
          asset_name: my-app-${{ matrix.os }}
          asset_content_type: application/zip

@zifeo
Copy link

zifeo commented Feb 20, 2023

Write permissions are required for the upload to succeed (either use token, permissions or change the settings > actions > general):
image

@svenstaro
Copy link
Owner

Since we now have retrying as of 2.5.0, I think we can consider the initial problem fixed.

@skjnldsv
Copy link

Still experiencing this on 2.5.0
The file is quite big: 1.178 GB

@svenstaro svenstaro reopened this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants