Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some issue for Bengali #1031

Merged
merged 1 commit into from Sep 2, 2022
Merged

Conversation

Aftabuzzaman
Copy link
Contributor

I am Bengali wikipedia editor & admin https://bn.wikipedia.org/wiki/user:আফতাবুজ্জামান https://w.wiki/5ejH I hope i will qualify here for fixing some issue in Bengali.

I fixed some issue here:

  • date & time - Bengali doesn't use "de" (I think spanish uses it). date & time should be like this: Friday, 2 September 2022
  • fixed some spelling
  • added translation for "byte"

I am Bengali wikipedia editor & admin https://bn.wikipedia.org/wiki/user:আফতাবুজ্জামান https://w.wiki/5ejH I hope i will qualify here for fixing some issue in Bengali.

I fixed some issue here:
- date & time - Bengali doesn't use "de" (I think spanish uses it). date & time should be like this: Friday, 2 September 2022
- fixed some spelling
- added translation for "byte"
@digitalfrost digitalfrost merged commit 8dec243 into svenfuchs:master Sep 2, 2022
@digitalfrost
Copy link
Collaborator

Thank you.

@Aftabuzzaman
Copy link
Contributor Author

Aftabuzzaman commented Sep 2, 2022

Thank you for accepting.

I have a question: https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/bn.yml#L69 this line has opening & closing apostrophe ('), while English verison https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/en.yml#L79 doesn't have it. Will it cause any problem? or it doesn't matter?

I will submit another patch. abbr_day_names: & abbr_month_names: is not actually abbreviated here (should be).

@digitalfrost
Copy link
Collaborator

digitalfrost commented Sep 3, 2022

Looking at https://github.com/svenfuchs/rails-i18n/blob/master/rails/locale/bn.yml#L72
I don't think the apostrophes are needed.
There is nothing dynamic going on such as a %{...}
and it seems that there is nothing special about the opening or closing characters.
Well spotted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants