Decompose I18n::Backend::Base#localize

[corlinus]

It allows to customise directives without overwriting whole localize method

[radar]

Thanks for the contribution!

Could you please demonstrate a use case of this feature?

[dmitry]

I believe it's a matter of extension format types.

[corlinus]

something like

module TranslatedZoneName
  private
  def translate_format(locale, format, object)
    super.gsub(
      '%O',
      (object.respond_to?(:time_zone) ? I18n.t(:"timezones.#{object.time_zone.name}",
                                              locale: locale, default: object.time_zone.name) : '')
    )
  end
end
I18n::Backend::Base.prepend TranslatedZoneName

(does not tested. just as an expample)

[radar]

Ok, thanks. Seems like a good addition to me.

Can you please write a test for this?

[radar]

Looks like this would be a good workaround for #210.

[corlinus]

I believe that there is no need to test something. I didn't change behaviour, split method though. And looks like it is not good practice to test private methods, it's better to test interface and i suppose it's already done. Maybe I don't understand somethig. Could you please explain than?

[dmitry]

Might be good to have the same method signature as parent has:

locale, object, format = :default, options = {}

[corlinus]

Do you mean that it would be better to have access to options inside translate_format for future customisation? format doen't need default value it will always set from parent method

[corlinus]

Hi @radar, so how do you think? could we merge or you still think I should write some tests on it?

[radar]

@corlinus I think it's fine to merge without them. I can't work out a way to write tests myself.

[radar]

Thanks for your contribution!