Fix Chained backend with KeyValue #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @esb, could you please try this PR out on your app and let us know if it fixes the issue that you reported? |
fatkodima
force-pushed
the
fix-key-value-subtrees
branch
from
8929e82
to
852b6e3
Compare
radar
reviewed
Feb 7, 2018
lib/i18n/backend/key_value.rb
Outdated
| end | ||
| value | ||
| end | ||
|
|
||
| def is_a?(klass) |
There was a problem hiding this comment.
I think the removal of these methods is not connected with this PR. Could you please add them back? I am concerned that it might lead to another regression.
fatkodima
force-pushed
the
fix-key-value-subtrees
branch
from
852b6e3
to
77c26aa
Compare
|
Tested on my application, and it solves the crash problem. |
|
Thank you for confirming @esb :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405.
With disabled subtrees, when we translate with
countand composed key is not found - we cannot easily tell: is "pluralized" key missing or we don't have that key at all. So let raise anI18n::MissingTranslationerror and allow the next backend in chain to handle this translation.This is similar to previous behavior (before #402), except that now it handles pluralized translations.
Correct me if I'm wrong or explained not clearly.