From b998c9609d48c3ba9512385da60b447150162186 Mon Sep 17 00:00:00 2001
From: paoloricciuti <ricciutipaolo@gmail.com>
Date: Sat, 27 Apr 2024 00:00:09 +0200
Subject: [PATCH 1/2] fix: hr, script and template as valid select children

---
 .changeset/cyan-squids-drive.md                      |  5 +++++
 packages/svelte/src/constants.js                     |  9 ++++++++-
 .../samples/invalid-node-placement-3/errors.json     |  1 +
 .../samples/invalid-node-placement-3/input.svelte    | 12 ++++++++++++
 4 files changed, 26 insertions(+), 1 deletion(-)
 create mode 100644 .changeset/cyan-squids-drive.md
 create mode 100644 packages/svelte/tests/validator/samples/invalid-node-placement-3/errors.json
 create mode 100644 packages/svelte/tests/validator/samples/invalid-node-placement-3/input.svelte

diff --git a/.changeset/cyan-squids-drive.md b/.changeset/cyan-squids-drive.md
new file mode 100644
index 000000000000..bb74431adf23
--- /dev/null
+++ b/.changeset/cyan-squids-drive.md
@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+hr, script and template as valid select children
diff --git a/packages/svelte/src/constants.js b/packages/svelte/src/constants.js
index 7755872ba51a..376809fb76b6 100644
--- a/packages/svelte/src/constants.js
+++ b/packages/svelte/src/constants.js
@@ -158,7 +158,14 @@ export function is_tag_valid_with_parent(tag, parent_tag) {
 	switch (parent_tag) {
 		// https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inselect
 		case 'select':
-			return tag === 'option' || tag === 'optgroup' || tag === '#text';
+			return (
+				tag === 'option' ||
+				tag === 'optgroup' ||
+				tag === '#text' ||
+				tag === 'hr' ||
+				tag === 'script' ||
+				tag === 'template'
+			);
 		case 'optgroup':
 			return tag === 'option' || tag === '#text';
 		// Strictly speaking, seeing an <option> doesn't mean we're in a <select>
diff --git a/packages/svelte/tests/validator/samples/invalid-node-placement-3/errors.json b/packages/svelte/tests/validator/samples/invalid-node-placement-3/errors.json
new file mode 100644
index 000000000000..fe51488c7066
--- /dev/null
+++ b/packages/svelte/tests/validator/samples/invalid-node-placement-3/errors.json
@@ -0,0 +1 @@
+[]
diff --git a/packages/svelte/tests/validator/samples/invalid-node-placement-3/input.svelte b/packages/svelte/tests/validator/samples/invalid-node-placement-3/input.svelte
new file mode 100644
index 000000000000..23c8edbbdf4f
--- /dev/null
+++ b/packages/svelte/tests/validator/samples/invalid-node-placement-3/input.svelte
@@ -0,0 +1,12 @@
+<script>
+</script>
+
+<select>
+	<option value="0">The</option>
+	<hr>
+	<script>
+		console.log("hei");
+	</script>
+	<template>Cool</template>
+	<option value="1">bug</option>
+</select>
\ No newline at end of file

From 4b0d428517a484939cd0b9b99bf53d5ae3dbaed0 Mon Sep 17 00:00:00 2001
From: Paolo Ricciuti <ricciutipaolo@gmail.com>
Date: Sat, 27 Apr 2024 08:00:16 +0200
Subject: [PATCH 2/2] Update .changeset/cyan-squids-drive.md

Co-authored-by: Jeremiasz Major <jrh.mjr@gmail.com>
---
 .changeset/cyan-squids-drive.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.changeset/cyan-squids-drive.md b/.changeset/cyan-squids-drive.md
index bb74431adf23..ae01d66fedb2 100644
--- a/.changeset/cyan-squids-drive.md
+++ b/.changeset/cyan-squids-drive.md
@@ -2,4 +2,4 @@
 "svelte": patch
 ---
 
-hr, script and template as valid select children
+fix: make hr, script and template valid select children