Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions on 3.50.0 don't act the same as 3.49.0 #7828

Closed
flayks opened this issue Sep 2, 2022 · 12 comments · Fixed by #7831
Closed

Transitions on 3.50.0 don't act the same as 3.49.0 #7828

flayks opened this issue Sep 2, 2022 · 12 comments · Fixed by #7831
Labels

Comments

@flayks
Copy link

flayks commented Sep 2, 2022

Describe the bug

On a simple "router" using different Page components wrapped with a PageTransition component, the transition with Svelte 3.50.0 does not seem to act the same as before.

The leaving Page component goes out without a transition and then the new one comes with the transition.

As it works with the same exact code on 3.49.0, I believe this is a bug, unless I missed something on the changelog.

Reproduction

Example with Svelte 3.49.0 with transition working as expected:
https://svelte.dev/repl/d498205ea0044e41a37da8f1c0d5728a?version=3.49.0

Same exact example with Svelte 3.50.0, but not acting as wanted this time:
https://svelte.dev/repl/d498205ea0044e41a37da8f1c0d5728a?version=3.50.0

Logs

No response

System Info

REPL

Severity

blocking an upgrade

@flayks flayks changed the title Transitions on 3.50.0 don't act like 3.49.0 Transitions on 3.50.0 don't act like the same as 3.49.0 Sep 2, 2022
@flayks flayks changed the title Transitions on 3.50.0 don't act like the same as 3.49.0 Transitions on 3.50.0 don't act the same as 3.49.0 Sep 2, 2022
Vages added a commit to Vages/svelte-snake-workshop that referenced this issue Sep 2, 2022
Pin Svelte to 3.49.0 to get the skull scale animation right again.

This issue seems related: sveltejs/svelte#7828
@jrmoynihan
Copy link

Seeing the same thing here. Was trying to debug my own code for a while before I simply reverted to 3.49 to temporarily solve the issue.

@fredguest
Copy link

Came here to make the same ticket. 3.50.0 adds at least 100ms of latency between the click and the transition. Very noticeable, had to lock the version to 3.49.0 to avoid it.

@thenbe
Copy link

thenbe commented Sep 3, 2022

A similar (same?) issue is happening with animate. Only 1 item in a given list is animating, the rest don't play their animations.

@MajorBreakfast
Copy link

MajorBreakfast commented Sep 3, 2022

Wanted to open this now as well :)

Here's my reproduction

Before: https://svelte.dev/repl/d4c3ea5ae72d4b259ef59d91370ea9d0?version=3.49.0
Now (broken): https://svelte.dev/repl/d4c3ea5ae72d4b259ef59d91370ea9d0?version=3.50.0

In Svelte 3.49.0, quickly transitioning works fine

svelte-3.49.0.mov

In Svelte 3.50.0, quickly switching makes it so that there are no visible transitions

svelte-3.50.0.mov

I'm seeing this not just in Safari, but also in Chrome and Firefox

gbl08ma added a commit to tnyim/jungletv that referenced this issue Sep 4, 2022
Svelte bug sveltejs/svelte#7828 is breaking transitions on 3.50
@jrmoynihan
Copy link

Wanted to open this now as well :)

Here's my reproduction

Before: https://svelte.dev/repl/d4c3ea5ae72d4b259ef59d91370ea9d0?version=3.49.0 Now (broken): https://svelte.dev/repl/d4c3ea5ae72d4b259ef59d91370ea9d0?version=3.50.0

In Svelte 3.49.0, quickly transitioning works fine

svelte-3.49.0.mov
In Svelte 3.50.0, quickly switching makes it so that there are no visible transitions

svelte-3.50.0.mov
I'm seeing this not just in Safari, but also in Chrome and Firefox

To be specific, it looks like the transitions run once. I think they're getting removed by mistake after the first transition occurs.

@baseballyama
Copy link
Member

I would appreciate it if you could check this PR and confirm that it works as expected.

#7831

@ScriptRaccoon
Copy link
Contributor

@baseballyama
Copy link
Member

The flip animations also do not work anymore.

I checked your REPL with #7831, and it works as same as 3.49.0.

@iolyd
Copy link

iolyd commented Sep 5, 2022

I checked your REPL with #7831, and it works as same as 3.49.0.

Not on my side. The 3.50.0 version is indeed broken and appended elements cause previous ones to jump rather than transition.

@baseballyama
Copy link
Member

baseballyama commented Sep 5, 2022

Did you check it with #7831 's code? Not 3.50.0.

I would like to check all reports get fixed in #7831.

@iolyd
Copy link

iolyd commented Sep 6, 2022

Oh my bad. Yep, it works with #7831 on my side.

@MajorBreakfast
Copy link

MajorBreakfast commented Sep 9, 2022

Just updated to svelte@3.50.1 and it works great again. Thx @baseballyama for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants