Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add link to vitest svelte example to test faq #7281

Merged
merged 1 commit into from Apr 8, 2022

Conversation

dominikg
Copy link
Member

vitest is newish but works great for vite+svelte apps (and should even work with the old standard template). Link it here.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@benmccann
Copy link
Member

I wonder if we should update the section that says "you can use a real browser powered by a library like Playwright, Puppeteer, or Cypress" to also say something along the lines of "The SvelteKit project creation wizard will setup Playwright for you as our preferred browser-based testing library"

@tanhauhau
Copy link
Member

I wonder if we should update the section that says "you can use a real browser powered by a library like Playwright, Puppeteer, or Cypress" to also say something along the lines of "The SvelteKit project creation wizard will setup Playwright for you as our preferred browser-based testing library"

agree

@dummdidumm
Copy link
Member

I'm against this, I wouldn't want to bless one specific solution here since we're in the context of Svelte here. At least I would only append that info, not replace the sentence and therefore remove the other options.

@dominikg
Copy link
Member Author

dominikg commented Apr 8, 2022

Also not a fan of sprinkling mentions of sveltekit at random bits of the svelte documentation.
We should be looking at both svelte and kit docs to add cross references where feasible once kit hits 1.0

@dummdidumm
Copy link
Member

Alright, then merge this as-is - we can always revisit this section later on.

@dummdidumm dummdidumm merged commit 6ef0aa2 into sveltejs:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants