Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename compiler css option #7270

Closed
benmccann opened this issue Feb 15, 2022 · 2 comments · Fixed by #7914
Closed

rename compiler css option #7270

benmccann opened this issue Feb 15, 2022 · 2 comments · Fixed by #7914

Comments

@benmccann
Copy link
Member

Describe the problem

I've never liked the css: boolean option name because it is unclear

Describe the proposed solution

perhaps it could be something like css: 'rendered-inline' | 'external' or externalizeCss: boolean

Alternatives considered

status quo

Importance

nice to have

@benmccann benmccann added this to the 4.x milestone Feb 15, 2022
@stalkerg
Copy link
Contributor

stalkerg commented Feb 17, 2022

I will be preferred more clear way:

cssUsage: 'rendered-inline' | 'external'

just "CSS" is not enough (not clear for me) but externalizeCss: boolean can be too limited in the future.

@Prinzhorn
Copy link
Contributor

Prinzhorn commented Feb 18, 2022

Consider making that 'inline' | 'external' | 'none' then. I want to compile client bundles without any CSS whatsoever. EMH333/esbuild-svelte#109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants