Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition leaves empty style element #7164

Closed
Restorn opened this issue Jan 20, 2022 · 6 comments
Closed

Transition leaves empty style element #7164

Restorn opened this issue Jan 20, 2022 · 6 comments

Comments

@Restorn
Copy link

Restorn commented Jan 20, 2022

Describe the bug

Introduced in #7114

The current version clears the stylesheet and removes reference to it but leaves the empty style element behind.
Every transition creates a new style duplicate.
Previous version kept stylesheet reference as a part of the document.

Reproduction

https://svelte.dev/repl/a6eddb766f9e474c92e5a23ba0bba362?version=3.46.2

Logs

No response

System Info

REPL

Severity

annoyance

@betamos
Copy link

betamos commented Feb 24, 2022

Note that this is a memory leak for all intents and purposes, so any long-running app that is heavy in transitions will pile up empty tags rather quickly.

Whoever is prioritizing issues in this project might want to consider bumping the priority up a notch :)

@MathiasWP
Copy link
Contributor

MathiasWP commented Feb 26, 2022

My pull request got approval for running workflows, but many of them failed during the install-step because of a weird type error. I have no problem finding out what caused the type error, but i need help from a maintainer to run the workflows again.

It feels weird that this bug has been part of Svelte so long.

@TrungRueta
Copy link

Alot reports regard to this issue, i got too and must find way to workaround by use tailwindcss transition with external plugin.. Any update about this?

@laztheripper
Copy link

Any update?

@baseballyama
Copy link
Member

I think this PR will fix the issue.

#7260

@Conduitry
Copy link
Member

Fixed in 3.50.0 - https://svelte.dev/repl/a6eddb766f9e474c92e5a23ba0bba362?version=3.50.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants